Install pip dependencies during the build #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the target branch should be |
xoriole
force-pushed
the
fix/build-script
branch
from
b312dcc to
3d0393b
Compare
xoriole
force-pushed
the
fix/build-script
branch
from
3d0393b to
1a90612
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
xoriole
requested review from
a team,
kozlovsky and
drew2a
and removed request for
a team
kozlovsky
approved these changes
Nov 22, 2021
drew2a
reviewed
Nov 22, 2021
| @@ -19,6 +19,9 @@ rm -rf build/debian/tribler/usr/share/tribler | |||
|
|
|||
| python3 build/update_version_from_git.py | |||
|
|
|||
| # ----- Install pip dependencies before the build | |||
| python3 -m pip install --upgrade -r src/requirements.txt | |||
There was a problem hiding this comment.
Issue: we should stop the build procedure in case of pip install error.
The possible, but not tested solution:
Suggested change
| python3 -m pip install --upgrade -r src/requirements.txt | |
| python3 -m pip install --upgrade -r src/requirements.txt || exit 1 |
| @@ -13,6 +13,9 @@ export RESOURCES=build/mac/resources | |||
| /bin/rm -rf dist | |||
|
|
|||
| # ----- Build | |||
| # ----- Install pip dependencies before the build | |||
| python3 -m pip install --upgrade -r src/requirements.txt | |||
There was a problem hiding this comment.
Issue: we should stop the build procedure in case of pip install error.
The possible, but not tested solution:
Suggested change
| python3 -m pip install --upgrade -r src/requirements.txt | |
| python3 -m pip install --upgrade -r src/requirements.txt || exit 1 |
| @@ -42,6 +42,9 @@ call build\win\clean.bat | |||
|
|
|||
| REM ----- Build | |||
|
|
|||
| REM ----- Install pip dependencies before the build | |||
| python3 -m pip install --upgrade -r src\requirements.txt | |||
There was a problem hiding this comment.
Issue: we should stop the build procedure in case of pip install error.
The possible, but not tested solution:
Suggested change
| python3 -m pip install --upgrade -r src\requirements.txt | |
| python3 -m pip install --upgrade -r src\requirements.txt || EXIT /B 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6518